Most of traders keep asking this question, it is a big desicion for beginners to chose between a lot of financial markets which one can possibility be the best for them. We have Forex market, share market, indices , metals , CFD, crypto market..... Etc
In my experience, I think the best market for you depends on your capital, skills and personality. I will explain which market you should chose according to your capital and personality:
Forex market: you need to be patience and not greedy because trading with margin system is very dangerous, so if you can't control your emotions and personality, then this market is not the best choice for you. Also this can be the best market for people whose want to make a lot of profit.
Share market: good for investors which means that you will need a lot of money to start getting good profits, it's a good market for traders who want to make profit of a 10% to 20% of their capital. But it takes a lot of knowledge and patient.
Crypto market: it's also good for investors but this time I am talking about long term investors, you can buy a good crypto currency and stock it in your wallet for years and sell it later. This market is profitable and not very risky.